Explicitly check QFile::open() return value.

2018-01-02 03:32:28 -05:00
parent 26f10d7faf
commit c7c97178ca
1 changed files with 12 additions and 11 deletions
@@ -78,22 +78,23 @@ namespace glabels
 		///
 		void Text::open()
 		{
-			mFile.setFileName( source() );
-			mFile.open( QIODevice::ReadOnly|QIODevice::Text );
-
 			mKeys.clear();
 			mNFieldsMax = 0;

-			if ( mLine1HasKeys && mFile.isOpen() )
+			mFile.setFileName( source() );
+			if (mFile.open( QIODevice::ReadOnly|QIODevice::Text ))
 			{
-				mKeys = parseLine();
-				if ( (mKeys.size() == 1) && (mKeys[0] == "") )
+				if ( mLine1HasKeys )
 				{
-					mKeys.clear();
-				}
-				else
-				{
-					mNFieldsMax = mKeys.size();
+					mKeys = parseLine();
+					if ( (mKeys.size() == 1) && (mKeys[0] == "") )
+					{
+						mKeys.clear();
+					}
+					else
+					{
+						mNFieldsMax = mKeys.size();
+					}
 				}
 			}
 		}