docs: update handoff — deployed, test pass underway, contrast fix pending deploy
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -1,4 +1,4 @@
|
|||||||
# Handoff: Table-fidelity feature batch — code-complete, pending deploy
|
# Handoff: Table-fidelity batch — deployed; manual test pass underway
|
||||||
|
|
||||||
## Session Metadata
|
## Session Metadata
|
||||||
- Created: 2026-05-18 20:57:36
|
- Created: 2026-05-18 20:57:36
|
||||||
@@ -13,16 +13,18 @@
|
|||||||
|
|
||||||
## Recent Commits (for context)
|
## Recent Commits (for context)
|
||||||
|
|
||||||
|
- `d10e581` fix(client): light outline on dark phantom glyphs for panel contrast — **NOT yet deployed**
|
||||||
|
- `0773300` docs: table-fidelity batch deployed to both instances
|
||||||
|
- `0c0e739` docs: session handoff
|
||||||
- `2e80800` docs: record table-fidelity feature batch as code-complete
|
- `2e80800` docs: record table-fidelity feature batch as code-complete
|
||||||
- `59717b3` docs: amend plan to reflect code-review fixes
|
- `59717b3` docs: amend plan to reflect code-review fixes
|
||||||
- `82a69d8` fix(client): key phantom-load effect on gameId, gate the drag ghost
|
- Feature implementation range: `be8ecd9..2e80800` (20 commits).
|
||||||
- `313837e` feat(client): wire the phantom opponent-model layer into the game view
|
|
||||||
- `816f89b` feat(client): phantom-piece palette component
|
|
||||||
- Full implementation range: `be8ecd9..2e80800` (20 commits).
|
|
||||||
|
|
||||||
## Current State Summary
|
## Current State Summary
|
||||||
|
|
||||||
The "table-fidelity feature batch" (three features Andrew Freiberg — Seth's dad, a physical-blind-chess player — requested by email) is **fully implemented, reviewed, committed to `main`, and deployed** (2026-05-18) to both live instances — `chess.sethpc.xyz` (CT 690) and `chess.local` (VDJ-RIG), both verified serving the new build (`index-DNriqpNJ.js`). All 12 plan tasks were executed via subagent-driven development with two-stage review per task plus a final whole-batch review. Build, typecheck, and the 87-test suite all pass. The one thing not done: a manual browser pass — the client UI was never click-tested (an agent can't drive a browser).
|
The "table-fidelity feature batch" (three features Andrew Freiberg — Seth's dad, a physical-blind-chess player — requested by email) is **fully implemented, reviewed, committed to `main`, and deployed** (2026-05-18) to both live instances — `chess.sethpc.xyz` (CT 690) and `chess.local` (VDJ-RIG). All 12 plan tasks were executed via subagent-driven development with two-stage review per task plus a final whole-batch review. Build, typecheck, and the 87-test suite all pass.
|
||||||
|
|
||||||
|
A **manual browser test pass is now underway** (Seth). It has surfaced one bug so far: opponent (black) phantom pieces had too little contrast on the dark `--panel` background. Fixed in `d10e581` — black piece glyphs in the palette, the Captures panel, and the drag-ghost now get a light text-shadow outline. **That fix is committed to `main` but NOT yet deployed** — the two live instances are at `0773300`, one commit behind `main`.
|
||||||
|
|
||||||
## Architecture Overview
|
## Architecture Overview
|
||||||
|
|
||||||
@@ -71,12 +73,16 @@ All recorded in `DECISIONS.md` under "Table-fidelity features (2026-05-18)" and
|
|||||||
|
|
||||||
## Immediate Next Steps
|
## Immediate Next Steps
|
||||||
|
|
||||||
1. **Manual browser/phone verification** of the now-live client UI — not done this session (an agent can't drive a browser). Open https://chess.sethpc.xyz, create a **blind game vs computer**, and check: the moderator panel shows White/Black-labelled attempt lines; the Captures panel updates on a capture; the phantom layer renders 16 seeded pieces; dragging a phantom moves it / off-board removes it; the palette places phantoms; a *tap* still makes real moves; phantoms persist across reload; vanilla mode shows no phantom UI; phantoms hide on game end. The phantom drag is the main mobile-risk surface — test on a phone.
|
1. **Decide and do the redeploy of `d10e581`** (the contrast fix). It is on `main` but not live. Seth was asked whether to deploy it now or batch it with further test-pass findings — undecided (he requested this handoff instead). Each redeploy drops in-memory games. Deploy steps: `CLAUDE.md` → Operations (both instances; for `chess.local` remember the explicit `systemctl restart` — see Potential Gotchas).
|
||||||
2. (Optional) Fix the `install-local.sh` redeploy gap — see Potential Gotchas.
|
2. **Continue the manual browser/phone test pass.** Open https://chess.sethpc.xyz, create a **blind game vs computer**, and check: the moderator panel shows White/Black-labelled attempt lines; the Captures panel updates on a capture; the phantom layer renders 16 seeded pieces; dragging a phantom moves it / off-board removes it; the palette places phantoms; a *tap* still makes real moves; phantoms persist across reload; vanilla mode shows no phantom UI; phantoms hide on game end. The phantom drag is the main mobile-risk surface — test on a phone.
|
||||||
|
3. **Check the board phantom glyph contrast.** `.phantom-b` (dark phantoms on the board) render at `opacity: 0.4` on the board squares; they have a dashed frame so the square reads, but the piece *type* may be hard to tell on dark squares. Flagged to Seth to eyeball during the test pass — if too faint, give `.phantom-b` a subtle light outline without killing the intentional translucency. (Same root cause as the `d10e581` fix, left alone for now because board phantoms are deliberately ghostly.)
|
||||||
|
4. (Optional) Fix the `install-local.sh` redeploy gap — see Potential Gotchas.
|
||||||
|
|
||||||
## Blockers / Open Questions
|
## Blockers / Open Questions
|
||||||
|
|
||||||
- **Client UI not manually verified in a browser.** The implementation passed build, `svelte-check`, the 87-test automated suite, and multi-stage code review — but an AI agent cannot run an interactive browser. The phantom drag-and-drop interaction in particular (pointer events, tap-vs-drag threshold, hit-testing) is verified only by review, not by clicking. Recommend Seth (or a browser-capable session) does the manual pass before/after deploy.
|
- **Deploy timing for `d10e581` (contrast fix) — undecided.** Seth was asked "deploy now, or batch with other test-pass findings?" and requested a handoff instead. Resolve next session. The live site lacks the contrast fix until then.
|
||||||
|
- **Board phantom glyph contrast — open question.** See Immediate Next Steps #3 — needs a human eye on a real board before deciding whether `.phantom-b` needs an outline.
|
||||||
|
- **Manual browser test pass is in progress, not complete.** Only the palette-contrast issue has been found and fixed so far; the rest of the checklist in Next Step #2 is unverified. The phantom drag-and-drop in particular (pointer events, tap-vs-drag, hit-testing) is verified only by code review, not by clicking.
|
||||||
|
|
||||||
## Deferred Items
|
## Deferred Items
|
||||||
|
|
||||||
@@ -87,7 +93,7 @@ All recorded in `DECISIONS.md` under "Table-fidelity features (2026-05-18)" and
|
|||||||
## Important Context
|
## Important Context
|
||||||
|
|
||||||
- **Everything is on `main` and pushed.** Seth explicitly chose to work directly on `main` (no feature branch). There is nothing to merge.
|
- **Everything is on `main` and pushed.** Seth explicitly chose to work directly on `main` (no feature branch). There is nothing to merge.
|
||||||
- **The work is code-complete but undeployed.** `chess.sethpc.xyz` is still running the pre-batch code until someone deploys. Deployment is an outward-facing action — confirm with Seth before doing it.
|
- **The feature batch is deployed and live** on both instances (`chess.sethpc.xyz` and `chess.local`) at commit `0773300`. The only un-deployed change is `d10e581` (the contrast fix). Deployment is outward-facing and drops in-memory games — confirm timing with Seth.
|
||||||
- **Two deploy instances now exist** (CLAUDE.md was updated mid-project): CT 690 / `chess.sethpc.xyz`, and `chess.local` on VDJ-RIG. Both need the update.
|
- **Two deploy instances now exist** (CLAUDE.md was updated mid-project): CT 690 / `chess.sethpc.xyz`, and `chess.local` on VDJ-RIG. Both need the update.
|
||||||
- The final review confirmed the security invariant holds: no `phantom` token anywhere under `packages/server/src/`, `buildView`/`geometric.ts` byte-for-byte unchanged.
|
- The final review confirmed the security invariant holds: no `phantom` token anywhere under `packages/server/src/`, `buildView`/`geometric.ts` byte-for-byte unchanged.
|
||||||
|
|
||||||
@@ -114,7 +120,7 @@ All recorded in `DECISIONS.md` under "Table-fidelity features (2026-05-18)" and
|
|||||||
- Spec: `docs/superpowers/specs/2026-05-18-table-fidelity-features-design.md`
|
- Spec: `docs/superpowers/specs/2026-05-18-table-fidelity-features-design.md`
|
||||||
- Plan: `docs/superpowers/plans/2026-05-18-table-fidelity-features.md`
|
- Plan: `docs/superpowers/plans/2026-05-18-table-fidelity-features.md`
|
||||||
- `DECISIONS.md` → "Table-fidelity features (2026-05-18)"
|
- `DECISIONS.md` → "Table-fidelity features (2026-05-18)"
|
||||||
- Live URL: https://chess.sethpc.xyz · Repo: https://git.sethpc.xyz/Seth/blind_chess (`main` at `2e80800`)
|
- Live URL: https://chess.sethpc.xyz (deployed at `0773300`) · Repo: https://git.sethpc.xyz/Seth/blind_chess (`main` at `d10e581`)
|
||||||
|
|
||||||
---
|
---
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user